feat: adding tag option for karpenter's default AWSNodeTemplate #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub <[email protected]>
pennywisdom
requested review from
aws-ia-ci,
a team,
parkand1,
shapirov103,
youngjeong46 and
elamaran11
as code owners
|
@youngjeong46 please review and share your thoughts on functional verification. |
simmyspike
approved these changes
Jul 25, 2023
youngjeong46
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adding tags option to the default provisioner so that Karpenter adds tags to all resources created, including EC2 Instances, EBS volumes and Launch Templates.
This change supports accounts with governance requirements where tags are required such as enforcing use of the AWS Instance Scheduler
Karpenter allows overrides of the default "Name" tag but does not allow overrides to restricted domains (such as "karpenter.sh", "karpenter.k8s.aws", and "kubernetes.io/cluster"). This ensures that Karpenter is able to correctly auto-discover machines that it owns, so Karpenter will validate these requirements itself.
An integration test would verify that the tags are added to EC2 instances, EBS volumes and Launch Templates.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.