ARM64 Support for External DNS #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elamaran11
requested review from
aws-ia-ci,
a team,
parkand1,
shapirov103 and
youngjeong46
as code owners
|
/do-e2e-test |
|
/do-e2e-tests |
lib/addons/external-dns/index.ts
Outdated
| release: 'blueprints-addon-external-dns', | ||
| version: '6.20.3', | ||
| version: '1.12.0', |
There was a problem hiding this comment.
fyi the latest version is at 1.13. Not sure if that one's ARM compatible.
There was a problem hiding this comment.
ya nice catch, fixed. It works now with 1.13.0
shapirov103
reviewed
Jun 22, 2023
lib/addons/external-dns/index.ts
Outdated
| release: 'blueprints-addon-external-dns', | ||
| version: '6.20.3', | ||
| version: '1.12.0', |
There was a problem hiding this comment.
is there a warning on deploy when using 1.12? There should be.
Has it been confirmed to work with arm?
There was a problem hiding this comment.
@shapirov103 It did throw a warning which i ignored. I fixed it now and it works perfectly fine with ARM. Please run e2e and merge.
|
/do-e2e-tests |
|
/do-e2e-tests |
1 similar comment
|
/do-e2e-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
ARM64 Support for External DNS
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.