Upgrading XRAY Addon #734
Merged
Upgrading XRAY Addon #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elamaran11
requested review from
aws-ia-ci,
a team,
parkand1,
shapirov103 and
youngjeong46
as code owners
1 task
shapirov103
reviewed
Jun 19, 2023
docs/addons/xray.md
Outdated
| 3. Configures Kubernetes service account with IRSA (`AWSXRayDaemonWriteAccess`) for communication between the cluster and the AWS X-Ray service | ||
| 1. Creates the `amazon-cloudwatch` namespace. | ||
| 2. Deploys the [`xray-daemon`](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/deploy_servicelens_CloudWatch_agent_deploy_EKS.html) manifests into the cluster. | ||
| 3. Configures Node role with policies (`CloudWatchAgentServerPolicy`, `AWSXRayDaemonWriteAccess`) for communication between the cluster and the CloudWatch and X-Ray service. |
There was a problem hiding this comment.
It looks like this setup deploys CW agent and XRay into the cluster. Why would we do that? Can we drop the agent deployment and just deploy XRay? I also assume that CloudWatchAgentServerPolicy won't be needed if we only deploy xray.
There was a problem hiding this comment.
@shapirov103 This is great feedback, fixed it. Please check and run e2e
shapirov103
reviewed
Jun 19, 2023
lib/addons/xray/xray-ds.yaml
Outdated
| name: amazon-cloudwatch | ||
| --- | ||
| # create role binding for XRay SDK to read config map | ||
| apiVersion: rbac.authorization.k8s.io/v1 |
There was a problem hiding this comment.
Why do we need these roles and role binding if the SA is not even referenced in the ds deployment?
There was a problem hiding this comment.
Makes sense. Removed it. Pleae check now.
|
/do-e2e-tests |
|
Let's wait for the e2e to pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.