Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change providers to resources, fix incorrenct paths, and fix parenthesis #721

Merged
merged 1 commit into from
Jun 12, 2023
Merged

change providers to resources, fix incorrenct paths, and fix parenthesis #721

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions docs/addons/external-dns.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ const app = new cdk.App();
const hostedZoneName = ...

const addOn = new blueprints.addons.ExternalDnsAddOn({
hostedZoneProviders: [hostedZoneName]; // can be multiple
hostedZoneResources: [hostedZoneName]; // can be multiple
});

const blueprint = blueprints.EksBlueprint.builder()
.addOns(addOn)
.resourceProvider(hostedZoneName, new blueprints.addons.LookupHostedZoneProvider(hostedZoneName))
.resourceProvider(hostedZoneName, new blueprints.LookupHostedZoneProvider(hostedZoneName))
.addOns(addOn)
.build(app, 'my-stack-name');
```
Expand Down Expand Up @@ -75,8 +75,8 @@ blueprints.EksBlueprint.builder()
// Register hosted zone1 under the name of MyHostedZone1
.resourceProvider("MyHostedZone1", new blueprints.LookupHostedZoneProvider(myDomainName))
.addOns(new blueprints.addons.ExternalDnsAddOn({
hostedZoneProviders: ["MyHostedZone1"];
})
hostedZoneResources: ["MyHostedZone1"];
}))
.build(...);
```

Expand All @@ -86,10 +86,10 @@ If the hosted zone ID is known, then the recommended approach is to use a `Impor
const myHostedZoneId = "";
blueprints.EksBlueprint.builder()
// Register hosted zone1 under the name of MyHostedZone1
.resourceProvider("MyHostedZone1", new blueprints.addons.ImportHostedZoneProvider(myHostedZoneId))
.resourceProvider("MyHostedZone1", new blueprints.ImportHostedZoneProvider(myHostedZoneId))
.addOns(new blueprints.addons.ExternalDnsAddOn({
hostedZoneProviders: ["MyHostedZone1"];
})
hostedZoneResources: ["MyHostedZone1"];
}))
.build(...);
```

Expand Down Expand Up @@ -128,10 +128,10 @@ blueprints.EksBlueprint.builder()
parentAccountId: parentDnsAccountId,
delegatingRoleName: 'DomainOperatorRole',
wildcardSubdomain: true
})
}))
.addOns(new blueprints.addons.ExternalDnsAddOn({
hostedZoneProviders: ["MyHostedZone1"];
})
hostedZoneResources: ["MyHostedZone1"];
}))
```

Expand Down