docs: add clarity for creating own VPC resource provider #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjaco13
requested review from
aws-ia-ci,
a team,
parkand1,
shapirov103,
youngjeong46 and
elamaran11
as code owners
elamaran11
reviewed
Jun 7, 2023
docs/resource-providers/index.md
Outdated
| @@ -40,7 +40,22 @@ Example implementations: | |||
| class VpcResourceProvider implements ResourceProvider<IVpc> { | |||
| provide(context: ResourceContext): IVpc { | |||
| const scope = context.scope; // stack | |||
| ... | |||
There was a problem hiding this comment.
I would rather add this is as a separate example that over writing on existing one.
| @@ -14,7 +14,7 @@ import * as blueprints from '@aws-quickstart/eks-blueprints'; | |||
|
|
|||
| const app = new cdk.App(); | |||
|
|
|||
| const addOn = new blueprints.addons.ClusterAutoscalerAddOn(); | |||
| const addOn = new blueprints.addons.ClusterAutoScalerAddOn(); | |||
There was a problem hiding this comment.
changed the s in ClusterAutoscalerAddOn to uppercase, since that's how you have to call the addon
shapirov103
reviewed
Jun 8, 2023
There was a problem hiding this comment.
@zjaco13 please see my comment and let me know if you have any questions. @elamaran11 please take a look at my comment as well.
shapirov103
approved these changes
Jun 9, 2023
|
/do-e2e-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #632
Description of changes:
Added documentation to explain creating VPC Resource Providers and added links to other resource providers
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.