Fix issue #709 #710
Merged
Fix issue #709 #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnaydenov
requested review from
aws-ia-ci,
a team,
parkand1,
shapirov103,
youngjeong46 and
elamaran11
as code owners
youngjeong46
reviewed
Jun 1, 2023
| @@ -42,8 +42,9 @@ const defaultProps: ClusterAutoScalerAddOnProps = { | |||
| * Version of the autoscaler, controls the image tag | |||
| */ | |||
| const versionMap = new Map([ | |||
| [KubernetesVersion.of("1.25"), "9.25.0"], | |||
| [KubernetesVersion.V1_25, "9.25.0"], | |||
| [KubernetesVersion.of("1.26"), "9.29.0"], | |||
There was a problem hiding this comment.
Lines 45 and 46 look duplicate.
There was a problem hiding this comment.
i fully agree with you they look dublicate , but i tried to keep them as close as posssible before my commit. Check the lines in how they look into 1.8.1 with version for V1.25
There was a problem hiding this comment.
that is fine, as long as the map entry exists for the target version of EKS, it is the correct approach. Version may become different in the future.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #709