Container Insights Addon Redesign and Upgrade. #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elamaran11
requested review from
aws-ia-ci,
a team,
parkand1,
shapirov103 and
youngjeong46
as code owners
shapirov103
reviewed
Jun 12, 2023
| serviceAccountNamespace = this.props.namespace; | ||
| } | ||
| else { | ||
| serviceAccountNamespace = "amazon-metrics" |
There was a problem hiding this comment.
Missing ;
applies elsewhere (we will need to apply a better linter however I believe make lint should catch it)
| @@ -65,6 +65,7 @@ export default class BlueprintConstruct { | |||
| }), | |||
| new blueprints.addons.XrayAdotAddOn(), | |||
| // new blueprints.addons.CloudWatchAdotAddOn(), | |||
| // new blueprints.addons.ContainerInsightsAddOn(), | |||
There was a problem hiding this comment.
Hmm, we have a few incompatible add-ons. We need to create a new e2e test for let's say CW observability with Cluster Autoscaler (currently incompatible with Karpenter). This can be deferred though.
|
@shapirov103 Fixed all link issues. Please run |
|
/do-e2e-tests |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.