fix: aws-load-balancer-controller service account missing IAM permissions #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielAtanasovski
requested review from
aws-ia-ci,
shapirov103,
youngjeong46,
elamaran11 and
a team
as code owners
elamaran11
reviewed
Oct 28, 2024
There was a problem hiding this comment.
LGTM. @shapirov103 I had similar issue recently. Lets test it.
|
/do-e2e-tests |
aws-ia-ci
requested changes
Oct 28, 2024
|
e2e test failure unrelated to the PR due to the default version change for cloudwatch insight. |
|
/do-e2e-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1096
Description of changes:
Expands the IAM permissions of the
aws-load-balancer-controllerrole to what is recommended by the addon:https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/docs/install/iam_policy.json
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.