[Karpenter] Make sure to preserve the SA during chart deletion #1012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Karpenter fails to shut down its nodes properly during cluster deletion due to a permission error caused by the premature deletion of the service account:
Solution:
Updated the dependency statement to ensure the correct deletion order:
This prevents permission errors by ensuring the service account is deleted after Karpenter components.
Testing
I wasn't able to properly test this because everytime i
npm link
ed my local version of this repo, i got this error:The stacktrace points to the first
new eks.KubernetesManifest()
call in my code. Is usingnpm link
the recommended method to test local changes?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.