chore(maintenance): drop support for Node.js 14 (#1802)

aws-powertools · Nov 24, 2023 · e2a0923 · e2a0923
1 parent 5361ad3
commit e2a0923
Show file tree

Hide file tree

Showing 36 changed files with 3,029 additions and 3,076 deletions.
diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml
@@ -70,7 +70,6 @@ body:
         - 20.x
         - 18.x
         - 16.x
-        - 14.x
     validations:
       required: true
   - type: dropdown

diff --git a/.github/workflows/reusable-run-linting-check-and-unit-tests.yml b/.github/workflows/reusable-run-linting-check-and-unit-tests.yml
@@ -10,7 +10,7 @@ jobs:
       NODE_ENV: dev
     strategy:
       matrix:
-        version: [14, 16, 18, 20]
+        version: [16, 18, 20]
       fail-fast: false
     steps:
       - name: Checkout code

diff --git a/.github/workflows/run-e2e-tests.yml b/.github/workflows/run-e2e-tests.yml
@@ -28,7 +28,7 @@ jobs:
             packages/parameters,
             packages/idempotency,
           ]
-        version: [14, 16, 18, 20]
+        version: [16, 18, 20]
         arch: [x86_64, arm64]
       fail-fast: false
     steps:

diff --git a/layers/src/canary-stack.ts b/layers/src/canary-stack.ts
@@ -41,7 +41,7 @@ export class CanaryStack extends Stack {
         '../tests/e2e/layerPublisher.class.test.functionCode.ts'
       ),
       handler: 'handler',
-      runtime: Runtime.NODEJS_14_X,
+      runtime: Runtime.NODEJS_16_X,
       functionName: `canary-${suffix}`,
       timeout: Duration.seconds(30),
       bundling: {

diff --git a/layers/src/layer-publisher-stack.ts b/layers/src/layer-publisher-stack.ts
@@ -37,7 +37,6 @@ export class LayerPublisherStack extends Stack {
       layerVersionName: props?.layerName,
       description: `Powertools for AWS Lambda (TypeScript) version ${powertoolsPackageVersion}`,
       compatibleRuntimes: [
-        Runtime.NODEJS_14_X,
         Runtime.NODEJS_16_X,
         Runtime.NODEJS_18_X,
         Runtime.NODEJS_20_X,
@@ -109,7 +108,7 @@ export class LayerPublisherStack extends Stack {
                 'node_modules/@aws-sdk/**/README.md ',
               ];
               const buildCommands: string[] = [];
-              // We need these modules because they are not included in the nodejs14x and nodejs16x runtimes
+              // We need these modules because they are not included in the nodejs16x runtimes
               const modulesToInstall: string[] = [
                 '@aws-sdk/client-dynamodb',
                 '@aws-sdk/util-dynamodb',

diff --git a/layers/tests/e2e/constants.ts b/layers/tests/e2e/constants.ts
@@ -1,5 +1,5 @@
 export const RESOURCE_NAME_PREFIX = 'Layers-E2E';
 export const ONE_MINUTE = 60 * 1000;
 export const TEST_CASE_TIMEOUT = 3 * ONE_MINUTE;
-export const SETUP_TIMEOUT = 5 * ONE_MINUTE;
+export const SETUP_TIMEOUT = 7 * ONE_MINUTE;
 export const TEARDOWN_TIMEOUT = 5 * ONE_MINUTE;
diff --git a/layers/tests/unit/layer-publisher.test.ts b/layers/tests/unit/layer-publisher.test.ts
@@ -25,12 +25,7 @@ describe('Class: LayerPublisherStack', () => {
     // Assess
     template.resourceCountIs('AWS::Lambda::LayerVersion', 1);
     template.hasResourceProperties('AWS::Lambda::LayerVersion', {
-      CompatibleRuntimes: [
-        'nodejs14.x',
-        'nodejs16.x',
-        'nodejs18.x',
-        'nodejs20.x',
-      ],
+      CompatibleRuntimes: ['nodejs16.x', 'nodejs18.x', 'nodejs20.x'],
       LicenseInfo: 'MIT-0',
       /* CompatibleArchitectures: [
         'x86_64',
-Original file line number
+Diff line change
@@ Expand Up / @@ -70,7 +70,6 @@ body: @@
             - 20.x
             - 18.x
             - 16.x
-            - 14.x
         validations:
           required: true
       - type: dropdown
@@ Expand Down @@