chore: Update pre-commit checks to ensure common standards are followed #377
Conversation
|
Opening early to show the output caught by these changes in CI |
| @@ -1,10 +1,10 @@ | |||
| # TODO - different name since if its not going to run on PRs | |||
There was a problem hiding this comment.
This workflow requires access to secrets for ROLE_TO_ASSUME which open source contributors outside the org will not have access, resulting in the error
Error: Credentials could not be loaded, please check your action inputs: Could not load credentials from any providers
I think most of what happens in this workflow is duplicated in https://github.com/aws-samples/aws-eks-accelerator-for-terraform/blob/main/.github/workflows/pre-commit.yaml, we could probably remove this and rely on the other tests we have in place. TBD
There was a problem hiding this comment.
This pr-test workflow was used mainly for PRs raised through branches(not from forks). This might not be required anymore since we have a proper CI solution for examples.
.github/workflows/pre-commit.yaml
Outdated
| @@ -1,97 +1,77 @@ | |||
| name: pre-commit | |||
|
|
|||
| on: | |||
| push: | |||
There was a problem hiding this comment.
This is better to show users on pull-requests and doesn't require any credential access so flipping to run on PRs
There was a problem hiding this comment.
Most of the other changes are just updates from the original workflow I created which now uses composite workflows
…-terraform into chore/update-pre-commit-checks
|
Closing for now to keep focus on launch activities - will re-open later |
1 similar comment
|
Closing for now to keep focus on launch activities - will re-open later |
What does this PR do?
Motivation
More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes