feat: Add optional path variable for the aws_load_balancer_controller aws_iam_policy #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadaj
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
nadaj
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
nadaj
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
nadaj
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
nadaj
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Failure
|
Tested this PR within my own project and was able to use external DNS with this setup. |
|
thank you for the PR - this will be resolved in the new addons module https://github.com/aws-ia/terraform-aws-eks-blueprints-addons |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Needed a custom path for the resource aws_iam_policy.aws_load_balancer_controller, since the roles used to deploy the resources have strict permissions on certain policy paths.
In addition, fixes issue with not being able to provide the path variable for the Karpenter add-on and the issue with having deprecated variables tied to external DNS.
More
pre-commit run -awith this PRFor Moderators
Additional Notes