Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/Enhancements 0824 #57

Merged
merged 17 commits into from
Aug 9, 2024
Merged

Fix/Enhancements 0824 #57

merged 17 commits into from
Aug 9, 2024

Conversation

ryanjpayne
Copy link
Contributor

@ryanjpayne ryanjpayne commented Aug 1, 2024 •
edited
Loading

This pull request includes minor fixes and enhancements:

  • FIX: SSM Distributor Secret in each ssm-region to ensure distributor package succeeds in all regions
  • FIX: Deploy Commercial to GovCloud root IOA stack
  • FIX: Remove Org ID Log Group to prevent conflicts when relaunching stack
  • Enhancement: Support deploying in Delegated Admin account
  • Enhancement: Add CloudTrail cfn resource to enable creating organization trail with CrowdStrike s3 bucket target to enable read only IOAs
  • Updates: Documentation and parameter formatting

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

Static analysis has failed. Please review and take action as appropriate.

2 similar comments
@aws-ia-automator-prod aws-ia-automator-prod
Copy link

Static analysis has failed. Please review and take action as appropriate.

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

Static analysis has failed. Please review and take action as appropriate.

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

Static analysis has failed. Please review and take action as appropriate.

kkvinjam
kkvinjam reviewed Aug 5, 2024
View reviewed changes
.taskcat.yml Show resolved Hide resolved
@kkvinjam
Copy link
Collaborator

kkvinjam commented Aug 5, 2024

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot requested changes Aug 5, 2024
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@kkvinjam
Copy link
Collaborator

kkvinjam commented Aug 6, 2024

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot requested changes Aug 6, 2024
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@kkvinjam
Copy link
Collaborator

kkvinjam commented Aug 6, 2024

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@kkvinjam
Copy link
Collaborator

kkvinjam commented Aug 6, 2024

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

Test environment issue.

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot requested changes Aug 6, 2024
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@ryanjpayne
Copy link
Contributor Author

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

You are not authorized to run end to end tests

@kkvinjam
Copy link
Collaborator

kkvinjam commented Aug 7, 2024

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot requested changes Aug 7, 2024
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@kkvinjam
Copy link
Collaborator

kkvinjam commented Aug 8, 2024

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

Failure at this latest checkin .

Error: ClientError An error occurred (ValidationError) when calling the CreateStack operation: Template format error: Output CSBucket is malformed. The Name field of every Export member must be specified and consist only of alphanumeric characters, colons, or hyphens.

@tbulding tbulding marked this pull request as draft August 8, 2024 21:21
@tbulding tbulding marked this pull request as ready for review August 8, 2024 21:21
@andrew-glenn andrew-glenn marked this pull request as draft August 8, 2024 21:43
@andrew-glenn andrew-glenn marked this pull request as ready for review August 8, 2024 21:43
@kkvinjam
Copy link
Collaborator

kkvinjam commented Aug 8, 2024

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot requested changes Aug 9, 2024
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@kkvinjam
Copy link
Collaborator

kkvinjam commented Aug 9, 2024

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

1 similar comment
@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot approved these changes Aug 9, 2024
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests completed successfully

@kkvinjam kkvinjam merged commit 466bf82 into aws-ia:main Aug 9, 2024
3 checks passed
@ryanjpayne ryanjpayne mentioned this pull request Aug 12, 2024
Closed
@ryanjpayne ryanjpayne deleted the enhancements-0824 branch August 12, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aws-ia-automator-prod aws-ia-automator-prod[bot] aws-ia-automator-prod[bot] approved these changes

@kkvinjam kkvinjam kkvinjam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanjpayne @kkvinjam