Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSM Distributor #40

Merged
merged 21 commits into from
Dec 19, 2023
Merged

Add SSM Distributor #40

merged 21 commits into from
Dec 19, 2023

Conversation

ryanjpayne
Copy link
Contributor

Add stacksets to deploy SSM Associations in each region/account to automatically install the Falcon sensor on Windows and Linux instances.

@ryanjpayne
Copy link
Contributor Author

@kkvinjam

@kkvinjam
Copy link
Collaborator

kkvinjam commented Dec 6, 2023

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

e2e test in progress

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

templates/crowdstrike_init_stack.yaml Outdated Show resolved Hide resolved
@kkvinjam
Copy link
Collaborator

kkvinjam commented Dec 8, 2023

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

e2e test in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot previously approved these changes Dec 8, 2023
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e tests completed successfully

@kkvinjam kkvinjam self-requested a review December 8, 2023 22:36
Copy link
Collaborator

@kkvinjam kkvinjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few additional issues reported by the scanner. Chimed you the details, please review and fix them. Thanks

Copy link
Collaborator

@kkvinjam kkvinjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the commented changes. Additional review and rule_supress needed at File: /templates/crowdstrike_init_stack.yaml:854-860

@@ -209,19 +233,44 @@
"CrowdStrikeCloudTrail": {
"Type": "AWS::CloudTrail::Trail",
"Condition": "ShouldCreateIOACloudTrailResource",
"Metadata": {
"cfn_nag": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect suppression. Example below. For additional information, refer to the doc.

  MyDB:
    Metadata:
      checkov:
        skip:
          - id: "CKV_AWS_157"
            comment: "Ensure that RDS instances have Multi-AZ enabled"
    Type: "AWS::RDS::DBInstance"
    Properties:

"cfn_nag": {
"rules_to_suppress": [
{
"id": "CKV_AWS_116",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. Incorrect suppression. Please fix.

@kkvinjam
Copy link
Collaborator

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

E2E tests in progress

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests completed successfully

@kkvinjam kkvinjam merged commit ee5223b into aws-ia:main Dec 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants