-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add configurable job timeouts widget. #611
Merged
karthikbekalp
merged 4 commits into
aws-deadline:mainline
from
karthikbekalp:addTimeoutGui
Feb 27, 2025
Merged
feat: Add configurable job timeouts widget. #611
karthikbekalp
merged 4 commits into
aws-deadline:mainline
from
karthikbekalp:addTimeoutGui
Feb 27, 2025
+607
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikbekalp
commented
Feb 21, 2025
karthikbekalp
commented
Feb 21, 2025
d3e7e3b
to
28fea88
Compare
joel-wong-aws
previously approved these changes
Feb 24, 2025
mwiebe
requested changes
Feb 25, 2025
28fea88
to
aae3dfa
Compare
aae3dfa
to
ea987b0
Compare
joel-wong-aws
previously approved these changes
Feb 26, 2025
mwiebe
requested changes
Feb 26, 2025
99f5bd7
to
ae092ca
Compare
mwiebe
previously approved these changes
Feb 27, 2025
Signed-off-by: Karthik Bekal Pattathana <[email protected]>
Signed-off-by: Karthik Bekal Pattathana <[email protected]>
Signed-off-by: Karthik Bekal Pattathana <[email protected]>
6705dac
to
eb01657
Compare
7284299
to
8e8f4dc
Compare
Signed-off-by: Karthik Bekal Pattathana <[email protected]>
8e8f4dc
to
61dbffd
Compare
|
mwiebe
approved these changes
Feb 27, 2025
joel-wong-aws
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
DCCs that depend on
deadline-cloud
needed an easy way to patch add timeouts GUI components to their submitters.What was the solution? (How)
Discussed with @AWS-Samuel about the simplest way to provide this capability. Kudos to @AWS-Samuel for his changes in Nuke which heavily inspires this PR.
Once this change is merged, I'll make corresponding changes in Cinema 4D so that we can add timeouts specifically for task run, Cinema 4D launch and shutdown. (We have a feature request for this )
What is the impact of this change?
Adds GUI that can be useful for adding timeouts to submitters.
How was this change tested?
I tried applying the changes for my locally built Cinema 4D.
Yes
Currently running it.
download
orasset_sync
modules? If so, then it is highly recommendedthat you ensure that the docker-based unit tests pass.
No
Was this change documented?
Are relevant docstrings in the code base updated?
Yes
Has the README.md been updated? If you modified CLI arguments, for instance.
No
Does this PR introduce new dependencies?
This library is designed to be integrated into third-party applications that have bespoke and customized deployment environments. Adding dependencies will increase the chance of library version conflicts and incompatabilities. Please evaluate the addition of new dependencies. See the Dependencies section of DEVELOPMENT.md for more details.
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.