Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add configurable job timeouts widget. #611

Merged
merged 4 commits into from
Feb 27, 2025

Conversation

karthikbekalp
Copy link
Contributor

@karthikbekalp karthikbekalp commented Feb 21, 2025

What was the problem/requirement? (What/Why)

DCCs that depend on deadline-cloud needed an easy way to patch add timeouts GUI components to their submitters.

What was the solution? (How)

Discussed with @AWS-Samuel about the simplest way to provide this capability. Kudos to @AWS-Samuel for his changes in Nuke which heavily inspires this PR.

Once this change is merged, I'll make corresponding changes in Cinema 4D so that we can add timeouts specifically for task run, Cinema 4D launch and shutdown. (We have a feature request for this )

What is the impact of this change?

Adds GUI that can be useful for adding timeouts to submitters.

How was this change tested?

I tried applying the changes for my locally built Cinema 4D.

  1. When the submitter is opened, the default timeouts are set.

Screenshot 2025-02-21 at 3 13 47 PM

  1. When one or more checkboxes are deactivated, there is a warning label at the bottom.

Screenshot 2025-02-21 at 3 14 10 PM

  1. When zero timeout is introduced.

Screenshot 2025-02-21 at 3 14 33 PM

  1. When zero timeout and checkboxes are deactivated.

Screenshot 2025-02-21 at 3 14 53 PM

  1. When submitting the job with zero timeout.

Screenshot 2025-02-21 at 3 15 10 PM

  • Have you run the unit tests?

Yes

  • Have you run the integration tests?

Currently running it.

  • Have you made changes to the download or asset_sync modules? If so, then it is highly recommended
    that you ensure that the docker-based unit tests pass.

No

Was this change documented?

  • Are relevant docstrings in the code base updated?
    Yes

  • Has the README.md been updated? If you modified CLI arguments, for instance.
    No

Does this PR introduce new dependencies?

This library is designed to be integrated into third-party applications that have bespoke and customized deployment environments. Adding dependencies will increase the chance of library version conflicts and incompatabilities. Please evaluate the addition of new dependencies. See the Dependencies section of DEVELOPMENT.md for more details.

  • This PR adds one or more new dependency Python packages. I acknowledge I have reviewed the considerations for adding dependencies in DEVELOPMENT.md.
  • This PR does not add any new dependencies.

Is this a breaking change?

No

Does this change impact security?

  • Does the change need to be threat modeled? For example, does it create or modify files/directories that must only be readable by the process owner?
    • If so, then please label this pull request with the "security" label. We'll work with you to analyze the threats.

No


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@karthikbekalp karthikbekalp force-pushed the addTimeoutGui branch 3 times, most recently from d3e7e3b to 28fea88 Compare February 21, 2025 23:51
joel-wong-aws
joel-wong-aws previously approved these changes Feb 24, 2025
joel-wong-aws
joel-wong-aws previously approved these changes Feb 26, 2025
@karthikbekalp karthikbekalp requested a review from mwiebe February 26, 2025 15:59
mwiebe
mwiebe previously approved these changes Feb 27, 2025
Signed-off-by: Karthik Bekal Pattathana <[email protected]>
Signed-off-by: Karthik Bekal Pattathana <[email protected]>
Signed-off-by: Karthik Bekal Pattathana <[email protected]>
@karthikbekalp karthikbekalp force-pushed the addTimeoutGui branch 2 times, most recently from 7284299 to 8e8f4dc Compare February 27, 2025 14:16
Signed-off-by: Karthik Bekal Pattathana <[email protected]>
@karthikbekalp karthikbekalp enabled auto-merge (squash) February 27, 2025 14:21
@karthikbekalp karthikbekalp requested a review from mwiebe February 27, 2025 15:06
@karthikbekalp karthikbekalp merged commit 978c631 into aws-deadline:mainline Feb 27, 2025
25 checks passed
@karthikbekalp karthikbekalp deleted the addTimeoutGui branch February 27, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants