fix: Fixed manifest download cli to download output for selected step … #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakshie95
changed the title
sakshie95
force-pushed
the
mainline
branch
2 times, most recently
from
58031e3 to
6eddd16
Compare
leongdl
reviewed
Feb 15, 2025
leongdl
reviewed
Feb 15, 2025
sakshie95
force-pushed
the
mainline
branch
4 times, most recently
from
80a1ed4 to
e2050fd
Compare
leongdl
reviewed
Feb 18, 2025
godobyte
reviewed
Feb 19, 2025
godobyte
reviewed
Feb 19, 2025
sakshie95
force-pushed
the
mainline
branch
4 times, most recently
from
ef66020 to
4a78f98
Compare
godobyte
previously approved these changes
Feb 19, 2025
leongdl
previously approved these changes
Feb 20, 2025
epmog
requested changes
Feb 20, 2025
epmog
approved these changes
Feb 20, 2025
leongdl
approved these changes
Feb 20, 2025
… or job by default. Added options to download only input or output too. Signed-off-by: Sakshi <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #602
What was the problem/requirement? (What/Why)
Manifest download cli does not download output manifests as it is intended to do for the provided step-id or the entire job if no step id is provided.
What was the solution? (How)
Added changes to download both input & output manifests (for step & dependencies if step-id is provided or for entire job if no step-id is provided) as the default behaviour. Also, added the option for downloading only input or output if customer wants to do that.
What is the impact of this change?
Manifest download clis will work as intended
How was this change tested?
Added integ tests, ran existing tests and tested the changes manually with the following steps:
hatch env prunehatch buildpip install <wheel file> --force-reinstallhatch run testhatch run integ:testManual test download cli:
deadline manifest download --job-id <job-id> --farm-id <farm-id> --queue-id <queue-id> <download location>downloadorasset_syncmodules? If so, then it is highly recommendedthat you ensure that the docker-based unit tests pass. No
Was this change documented?
Does this PR introduce new dependencies?
This library is designed to be integrated into third-party applications that have bespoke and customized deployment environments. Adding dependencies will increase the chance of library version conflicts and incompatabilities. Please evaluate the addition of new dependencies. See the Dependencies section of DEVELOPMENT.md for more details.
Is this a breaking change?
N/A, because the manifest cli & api is in beta. Also default behaviour for the cli was always intended to be to download 'all' but it downloads only
inputright now.Does this change impact security?
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.