fix: Allow Identifier's in custom host requirements. #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Osiowy <[email protected]>
erico-aws
force-pushed
the
identifiers_in_host_requirements
branch
from
a414115 to
c63fa55
Compare
epmog
approved these changes
Jan 29, 2025
| @@ -72,11 +73,19 @@ | |||
| ) | |||
|
|
|||
| CUSTOM_CAPABILITY_NAME_REGEX = "^(\\.[a-zA-Z][a-zA-Z0-9]{0,63})+$" | |||
There was a problem hiding this comment.
nit: this wasn't and still isn't actually used anywhere so we can actually remove this.
lucaseck
approved these changes
Jan 29, 2025
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #553
What was the problem/requirement? (What/Why)
Users could not enter identifiers in the name field of custom host requirements. It was restricted to just letters, numbers, dashes and underscores up to 99 characters. This doesn't match the attributes of an Identifier as outlined in the OpenJD specification.
What was the solution? (How)
What is the impact of this change?
Names for custom host requirements should work now and should be validated correctly.
How was this change tested?
Added Unit tests for the changes.
Deployed changes to Blender for testing to make sure it worked as expected.
Was this change documented?
No.
Does this PR introduce new dependencies?
This library is designed to be integrated into third-party applications that have bespoke and customized deployment environments. Adding dependencies will increase the chance of library version conflicts and incompatabilities. Please evaluate the addition of new dependencies. See the Dependencies section of DEVELOPMENT.md for more details.
Is this a breaking change?
No.
Does this change impact security?
No.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.