Revert "chore(deps): update pyinstaller requirement from ==5.13.* to … #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moorec-aws
approved these changes
Nov 19, 2024
jericht
approved these changes
Nov 19, 2024
… ==6.11.* (aws-deadline#487)" This reverts commit 0e41685. Signed-off-by: Eric Osiowy <[email protected]>
erico-aws
force-pushed
the
revert-pyinstaller
branch
from
e0b5cb1 to
7a91385
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0e41685.
What was the problem/requirement? (What/Why)
An update to the pyinstaller dependency was merged unintentionally. It required more work than a simple version bump.
#487
What was the solution? (How)
Revert that commit.
What is the impact of this change?
Unblock release process for deadline installers.
How was this change tested?
Ran
hatch run test.Was this change documented?
No.
Does this PR introduce new dependencies?
This library is designed to be integrated into third-party applications that have bespoke and customized deployment environments. Adding dependencies will increase the chance of library version conflicts and incompatabilities. Please evaluate the addition of new dependencies. See the Dependencies section of DEVELOPMENT.md for more details.
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.