Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Manifest download cli does not paginate through step dependencies #607

Open
sakshie95 opened this issue Feb 19, 2025 · 0 comments
Open
Labels
bug Something isn't working job attachments For an issue with job attachments

Comments

@sakshie95
Copy link
Contributor

Describe the bug

Manifest download cli downloads inputs for a step & the outputs of it step-step dependencies if they exist. Right now, it just goes through the first page of the response for list_step_dependencies api and does not take into account pagination

Expected Behaviour

It should paginate through the list_step_dependencies response and get all step dependencies for the step parameter provided.

Current Behaviour

it just goes through the first page of the response for list_step_dependencies api and does not take into account pagination

Reproduction Steps

  1. Find a job template with many step-step dependencies (with 1 step having more step dependencies than the defined pagesize of 100)
  2. Run manifest download command with a job and step id: deadline manifest download --job-id <job-id> --step-id <step-id> --farm-id <farm-id> --queue-id <queue-id> <local-path>

Environment

At minimum:

  1. Operating system (e.g. Windows Server 2022; Amazon Linux 2023; etc.) - Any, does not matter
  2. Output of python3 --version - 3.10.13
  3. Output of deadline --version - 0.49.6
  4. If this is from a version installed by the Deadline Cloud Submitter installer, then what version of the submitter installer? N/A

Please share other details about your environment that you think might be relevant to reproducing the bug.

@sakshie95 sakshie95 added bug Something isn't working job attachments For an issue with job attachments labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working job attachments For an issue with job attachments
Projects
None yet
Development

No branches or pull requests

1 participant