chore: add quotes to variables in shell scripts #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moorec-aws
force-pushed
the
moorec/unqouted-variables
branch
from
3e8d9b7 to
21b72de
Compare
moorec-aws
changed the title
ddneilson
suggested changes
Jun 21, 2024
moorec-aws
force-pushed
the
moorec/unqouted-variables
branch
2 times, most recently
from
e5a5694 to
e184024
Compare
jusiskin
requested changes
Jul 4, 2024
moorec-aws
force-pushed
the
moorec/unqouted-variables
branch
2 times, most recently
from
70d90b1 to
6e0550b
Compare
jusiskin
requested changes
Jul 4, 2024
|
erico-aws
added
the
response-requested
moorec-aws
force-pushed
the
moorec/unqouted-variables
branch
from
0db8d47 to
e9a9a9b
Compare
moorec-aws
force-pushed
the
moorec/unqouted-variables
branch
from
e9a9a9b to
feb12fb
Compare
Signed-off-by: Charles Moore <[email protected]>
moorec-aws
force-pushed
the
moorec/unqouted-variables
branch
from
feb12fb to
7d3b9a9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We have a bunch of unquoted variables in our shell scripts
What was the solution? (How)
Add the quotes
What is the impact of this change?
n/a
How was this change tested?
hatch run testWas this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.