Optional extension around parameter validation of loaded callback fun…

…ction This will call the `validate_function_signature` function within the new deadline-cloud callback loader to validate the parameters of the loaded callback.py This is optional as I am unsure how much we care about this. It would fail anyways but this way at least we could raise some error notifying people that the signature looks incorrect. Signed-off-by: Alex Hughes <[email protected]>
aws-deadline · Apr 19, 2024 · 111433b · 111433b
1 parent 72035a9
commit 111433b
Showing 1 changed file with 17 additions and 0 deletions.
diff --git a/src/deadline/nuke_submitter/deadline_submitter_for_nuke.py b/src/deadline/nuke_submitter/deadline_submitter_for_nuke.py
@@ -344,6 +344,15 @@ def on_create_job_bundle_callback(
                         trace=traceback.format_exc()
                     )
                 )
+
+            if not callback_loader.validate_function_signature(on_pre_submit_callback):
+                raise DeadlineOperationError(
+                    "Python function at {path}:on_pre_submit_callback does not match function signature: {signature}."
+                    .format(
+                        path=os.environ.get("DEADLINE_PRE_SUBMIT_CALLBACK"),
+                        signature=callback_loader.CALLBACK_REFERENCE_SIGNATURE,
+                    )
+                )
             callback_kwargs["on_pre_submit_callback"] = on_pre_submit_callback
 
         if os.path.exists(os.environ.get("DEADLINE_POST_SUBMIT_CALLBACK", "")):
@@ -361,6 +370,14 @@ def on_create_job_bundle_callback(
                         trace=traceback.format_exc()
                     )
                 )
+            if not callback_loader.validate_function_signature(on_post_submit_callback):
+                raise DeadlineOperationError(
+                    "Python function at {path}:on_post_submit_callback does not match function signature: {signature}."
+                    .format(
+                        path=os.environ.get("DEADLINE_POST_SUBMIT_CALLBACK"),
+                        signature=callback_loader.CALLBACK_REFERENCE_SIGNATURE,
+                    )
+                )
             callback_kwargs["on_post_submit_callback"] = on_post_submit_callback