fix: ensure defaultArnoldRenderOptions are loaded when using mtoa #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epmog
approved these changes
Dec 21, 2023
Signed-off-by: Trevor Blanchard <[email protected]>
ttblanchard
force-pushed
the
blantrev/fixmayamtoasubmitter
branch
from
e5483f2 to
75e807d
Compare
AWS-Samuel
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The Maya Submitter intermittently throws an exception upon opening. This only happens when the mtoa plugin is loaded.
What was the solution? (How)
When the submitter detects Arnold as the renderer, it will try to access Arnold properties, however we are never loading the Arnold options.
Now before we try to access those properties we ensure the mtoa
createOptionshas been called.What is the impact of this change?
The Submitter no longer throws an exception when the mtoa plugin is loaded.
How was this change tested?
Installed this version of the plugin on my local Maya 2023 install, then:
Previously these steps would trigger an exception.
Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
No, this change only effects plugin loading.
Was this change documented?
No, it's only fixing a regression.
Is this a breaking change?
No.