Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Allow specifying MAYAPY exe via environment #200

Merged

Conversation

Ahuge
Copy link
Contributor

@Ahuge Ahuge commented Nov 29, 2024

This matches the logic we have implemented in the deadline-cloud-for-cinema-4d package.

What was the problem/requirement? (What/Why)

The assumption that the executable mayapy exists on the PATH doesn't always make sense, often it is easier to specify the version of MAYA to use by explicit path and using an environment variable is an easy way to do this for customers.

What was the solution? (How)

We have defined a new environment variable MAYAPY_EXECUTABLE which follows the naming from
deadline-cloud-for-cinema-4d of <EXE_NAME>_EXECUTABLE

What is the impact of this change?

Additional functionality to override the mayapy executable that is used via the environment variable.

Was this change documented?

Yes this was documented in the README.md similar to how it was done in the deadline-cloud-for-cinema-4d package

Is this a breaking change?

No


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Ahuge Ahuge requested a review from a team as a code owner November 29, 2024 19:22
@Ahuge Ahuge force-pushed the ah/feature/environment-variable-mayapy branch from e2b8778 to d6abac3 Compare November 29, 2024 19:24
@Ahuge Ahuge changed the title Allow specifying MAYAPY exe via environment Bug: Allow specifying MAYAPY exe via environment Nov 29, 2024
@Ahuge Ahuge changed the title Bug: Allow specifying MAYAPY exe via environment Feat: Allow specifying MAYAPY exe via environment Nov 29, 2024
@Ahuge Ahuge changed the title Feat: Allow specifying MAYAPY exe via environment feat: Allow specifying MAYAPY exe via environment Nov 29, 2024
epmog
epmog previously approved these changes Dec 2, 2024
@Ahuge Ahuge force-pushed the ah/feature/environment-variable-mayapy branch from d6abac3 to 5f66664 Compare December 2, 2024 21:38
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@Ahuge
Copy link
Contributor Author

Ahuge commented Dec 2, 2024

Updated to use MAYA_ADAPTOR_MAYAPY_EXECUTABLE naming instead of MAYA_ADAPTOR_MAYAPY_EXE, which matches Nuke

jericht
jericht previously approved these changes Dec 2, 2024
Ahuge added 2 commits December 2, 2024 13:56
This matches the logic we have implemented in the
`deadline-cloud-for-nuke` package.

Signed-off-by: Alex Hughes <[email protected]>
@Ahuge Ahuge force-pushed the ah/feature/environment-variable-mayapy branch from 5f66664 to f353599 Compare December 2, 2024 21:57
Copy link

sonarqubecloud bot commented Dec 2, 2024

@Ahuge
Copy link
Contributor Author

Ahuge commented Dec 2, 2024

Updated to use MAYAPY_EXECUTABLE naming instead of MAYA_ADAPTOR_MAYAPY_EXE, after a conversation with Morgan and Mark

@epmog epmog changed the title feat: Allow specifying MAYAPY exe via environment feat!: Allow specifying MAYAPY exe via environment Dec 2, 2024
@epmog epmog merged commit 29634ca into aws-deadline:mainline Dec 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants