-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Allow specifying MAYAPY exe via environment #200
feat!: Allow specifying MAYAPY exe via environment #200
Conversation
e2b8778
to
d6abac3
Compare
d6abac3
to
5f66664
Compare
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Updated to use |
This matches the logic we have implemented in the `deadline-cloud-for-nuke` package. Signed-off-by: Alex Hughes <[email protected]>
Signed-off-by: Alex Hughes <[email protected]>
5f66664
to
f353599
Compare
|
Updated to use MAYAPY_EXECUTABLE naming instead of MAYA_ADAPTOR_MAYAPY_EXE, after a conversation with Morgan and Mark |
This matches the logic we have implemented in the
deadline-cloud-for-cinema-4d
package.What was the problem/requirement? (What/Why)
The assumption that the executable
mayapy
exists on the PATH doesn't always make sense, often it is easier to specify the version of MAYA to use by explicit path and using an environment variable is an easy way to do this for customers.What was the solution? (How)
We have defined a new environment variable
MAYAPY_EXECUTABLE
which follows the naming fromdeadline-cloud-for-cinema-4d
of<EXE_NAME>_EXECUTABLE
What is the impact of this change?
Additional functionality to override the mayapy executable that is used via the environment variable.
Was this change documented?
Yes this was documented in the
README.md
similar to how it was done in thedeadline-cloud-for-cinema-4d
packageIs this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.