fix: frame override checkbox does not enable frame list in Maya 2025 #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morgan Epp <[email protected]>
|
mwiebe
approved these changes
Oct 28, 2024
jericht
approved these changes
Oct 28, 2024
godobyte
approved these changes
Oct 28, 2024
jairaws
approved these changes
Oct 28, 2024
leongdl
approved these changes
Oct 28, 2024
leongdl
reviewed
Oct 28, 2024
| @@ -200,4 +200,4 @@ def activate_frame_override_changed(self, state): | |||
| """ | |||
| Set the activated/deactivated status of the Frame override text box | |||
| """ | |||
| self.frame_override_txt.setEnabled(state == Qt.Checked) | |||
| self.frame_override_txt.setEnabled(Qt.CheckState(state) == Qt.Checked) | |||
There was a problem hiding this comment.
Super nit, can 199 state use a type so bugs like this can be found via lint
leongdl
approved these changes
Oct 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Maya 2025 support was just added that uses PySide6. PySide6 changed how they handle enum values: https://doc.qt.io/qtforpython-6/considerations.html#the-new-python-enums. So the way we're checking does not enable the frame list properly.
What was the solution? (How)
PR for inspiration: aws-deadline/deadline-cloud-for-blender#90
What is the impact of this change?
It works!
How was this change tested?
Will test manually first before merging.
Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
N/A, this is for the UI, not the job bundles.
Was this change documented?
N/A
Is this a breaking change?
Nope
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.