Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: publish release #132

Merged
merged 3 commits into from
Apr 1, 2024
Merged

feat!: publish release #132

merged 3 commits into from
Apr 1, 2024

Conversation

moorec-aws
Copy link
Contributor

What was the problem/requirement? (What/Why)

We're about to publicly release this library. We need to prep the build process for that.

What was the solution? (How)

  • Bump deadline-cloud to 0.47.0 and openjd-adaptor-runtime to 0.7.0

  • Update the build script to no longer define a PIP_INDEX_URL -- the environment variable
    that we used to interface with our internal repository during private development.

  • Update the code quality check to pull deps from the public PyPI, so
    that we're testing as customers would use it.

  • Use the public PyPI in the release flows since all deps are now
    available publicly. This ensures that the artifact we release can be
    built & used by anyone using PyPI.

What is the impact of this change?

Release readiness

How was this change tested?

Tests will not pass until dependencies are released

Was this change documented?

No

Is this a breaking change?

No, but it is being marked as one to force a minor version bump when we release.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@moorec-aws moorec-aws requested a review from a team as a code owner March 30, 2024 05:26
jericht
jericht previously approved these changes Mar 31, 2024
@jericht
Copy link
Contributor

jericht commented Mar 31, 2024

nit: commit and PR title are "publish release" vs. "public release" in all the other repos

moorec-aws and others added 3 commits April 1, 2024 16:56
Signed-off-by: Charles Moore <[email protected]>
Signed-off-by: Morgan Epp <[email protected]>
@epmog epmog merged commit cee87da into mainline Apr 1, 2024
6 checks passed
@epmog epmog deleted the public-release branch April 1, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants