Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ResourceAssociation update operation #8

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Add ResourceAssociation update operation #8

merged 1 commit into from
Sep 24, 2024

Conversation

michaelhtm
Copy link
Member

@michaelhtm michaelhtm commented Sep 23, 2024 •
edited
Loading

Description of changes:

This change allows the ram controller to associate
resourceArns, principals, and sources to a resource share

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested a review from a-hilaly September 23, 2024 21:16
@ack-prow ack-prow bot added the approved label Sep 23, 2024
@michaelhtm michaelhtm force-pushed the associate-resources branch 9 times, most recently from 522bc5a to a2c6e05 Compare September 24, 2024 01:00
a-hilaly
a-hilaly reviewed Sep 24, 2024
View reviewed changes
pkg/resource/resource_share/hooks.go Outdated Show resolved Hide resolved
pkg/resource/resource_share/hooks.go Outdated Show resolved Hide resolved
pkg/resource/resource_share/hooks.go Show resolved Hide resolved
pkg/resource/resource_share/hooks.go Outdated Show resolved Hide resolved
templates/hooks/resource_share/sdk_update_pre_build_request.go.tpl Show resolved Hide resolved
@a-hilaly
Copy link
Member

also @michaelhtm PR description please :)

@michaelhtm michaelhtm changed the title Add ResourceAssociation update operation Add ResourceAssociation update operation Sep 24, 2024
@michaelhtm
Add ResourceAssociation update operation
1424d8f 
This change allows the ram controller to associate
resourceArns, principals, and sources to a `resource share`
@a-hilaly
Copy link
Member

/retest

1 similar comment
@a-hilaly
Copy link
Member

/retest

@ack-prow ACK Prow
Copy link

ack-prow bot commented Sep 24, 2024

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ram-verify-attribution 1424d8f link false /test ram-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

a-hilaly
a-hilaly approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
@ack-prow ACK Prow
Copy link

ack-prow bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit ae27ee8 into aws-controllers-k8s:main Sep 24, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

Assignees

@a-hilaly a-hilaly

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelhtm @a-hilaly