Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to ACK runtime v0.39.0, code-generator v0.39.1 #10

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Update to ACK runtime v0.39.0, code-generator v0.39.1 #10

merged 1 commit into from
Oct 15, 2024

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Oct 10, 2024

Update to ACK runtime v0.39.0, code-generator v0.39.1

NOTE:
This PR increments the release version of service controller from v0.0.5 to v0.0.6

Once this PR is merged, release v0.0.6 will be automatically created for ram-controller

Please close this PR, if you do not want the new patch release for ram-controller

stdout for make build-controller:

building ack-generate ... ok.
==== building ram-controller ====
Copying common custom resource definitions into ram
Building Kubernetes API objects for ram
Generating deepcopy code for ram
Generating custom resource definitions for ram
Building service controller for ram
Generating RBAC manifests for ram
Running gofmt against generated code for ram
Updating additional GitHub repository maintenance files
==== building ram-controller release artifacts ====
Building release artifacts for ram-v0.0.6
Generating common custom resource definitions
Generating custom resource definitions for ram
Generating RBAC manifests for ram

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Oct 10, 2024
@ack-prow ack-prow bot requested review from a-hilaly and michaelhtm October 10, 2024 03:57
a-hilaly
a-hilaly approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added lgtm Indicates that a PR is ready to be merged. approved labels Oct 12, 2024
a-hilaly
a-hilaly reviewed Oct 12, 2024
View reviewed changes
pkg/resource/resource_share/sdk.go Outdated
@@ -391,7 +391,7 @@ func (rm *resourceManager) sdkUpdate(
}

if delta.DifferentAt("Spec.ResourceARNs") || delta.DifferentAt("Spec.Principals") || delta.DifferentAt("Spec.Sources") {
if err := rm.syncResourceShareResources(ctx, desired, latest); err != nil {
if err := rm.syncResources(ctx, desired, latest); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @michaelhtm

a-hilaly
a-hilaly approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@a-hilaly
Copy link
Member

/retest

michaelhtm
michaelhtm approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@michaelhtm
Copy link
Member

/hold

@ack-prow ack-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2024
@michaelhtm
Copy link
Member

/retest

1 similar comment
@michaelhtm
Copy link
Member

/retest

@ack-prow ack-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2024
@michaelhtm michaelhtm force-pushed the ack-bot/rt-v0.39.0-codegen-v0.39.1 branch from 94c66d8 to dd889aa Compare October 15, 2024 18:25
@ack-prow ACK Prow
Copy link

ack-prow bot commented Oct 15, 2024

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ram-verify-attribution dd889aa link false /test ram-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@michaelhtm
Copy link
Member

/unhold

@ack-prow ack-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2024
a-hilaly
a-hilaly approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @michaelhtm
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2024
@ack-prow ACK Prow
Copy link

ack-prow bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit d3e64cb into main Oct 15, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelhtm michaelhtm michaelhtm approved these changes

@a-hilaly a-hilaly a-hilaly approved these changes

Assignees

@a-hilaly a-hilaly

@michaelhtm michaelhtm

Labels
approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ack-bot @a-hilaly @michaelhtm