Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix:464] Replaced imports with parameters and removed custom resource. #465

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

zechariahks
Copy link

Issue #, if available: 464

Description of changes:

  • Replaced the ImportValue statements with Parameter values.
  • Introduced parameters for networking resources like VpcId and Subnet Ids.
  • Removed the custom resource that was used to create Lambda function version. CloudFormation supports the version resource now. We don't need a custom resource.
  • Other minor formatting changes.
  • Updated ReadMe with the new parameters.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ericzbeard ericzbeard merged commit 9d89d70 into aws-cloudformation:main Feb 24, 2025
@zechariahks zechariahks deleted the zech_issue_464 branch February 24, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants