Fix: Replace SecurityGroups with SecurityGroupIds in EC2 resource #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the EC2 instance template to reference security groups by ID instead of name. - Resolved conflict between subnet and groupName parameters, preventing errors during stack creation.
ericzbeard
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes an issue where specifying the security group name (
groupName) in theAWS::EC2::Instanceresource along with the subnet parameter causes an error. The security group should be referenced by its ID rather than by its name.Changes
SecurityGroupsparameter toSecurityGroupIdsand usedFn::GetAttto retrieve the security group ID.Background
The AWS EC2 API does not allow the use of
groupName(security group name) in combination withsubnet. Instead, security groups must be referenced by their ID. This change addresses that limitation by updating the template to use the security group ID.Testing
The updated template was successfully tested by creating a stack without encountering errors.