-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@aws-amplify/ui-react): wrap withAuthenticator with AmplifyAuthContainer
#8243
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8243 +/- ##
=======================================
Coverage 77.87% 77.87%
=======================================
Files 236 236
Lines 16513 16513
Branches 3539 3539
=======================================
Hits 12859 12859
Misses 3543 3543
Partials 111 111 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @wlee221 !
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Description of changes
This PR wraps App with
AmplifyAuthContainer
to get the benefit of #8181 by default.Issue #, if available
#5782
Description of how you validated changes
I've published this to
ui-preview
tag. Tested onwithAuthenticator
sample.Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.