Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@aws-amplify/ui-react): wrap withAuthenticator with AmplifyAuthContainer #8243

Merged
merged 5 commits into from
May 12, 2021

Conversation

wlee221
Copy link
Contributor

@wlee221 wlee221 commented May 7, 2021

Description of changes

This PR wraps App with AmplifyAuthContainer to get the benefit of #8181 by default.

Issue #, if available

#5782

Description of how you validated changes

I've published this to ui-preview tag. Tested on withAuthenticator sample.

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2021

Codecov Report

Merging #8243 (b867520) into main (bc5a21f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8243   +/-   ##
=======================================
  Coverage   77.87%   77.87%           
=======================================
  Files         236      236           
  Lines       16513    16513           
  Branches     3539     3539           
=======================================
  Hits        12859    12859           
  Misses       3543     3543           
  Partials      111      111           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc5a21f...b867520. Read the comment docs.

@wlee221 wlee221 requested a review from ericclemmons May 10, 2021 17:38
@ericclemmons ericclemmons added this to the Current UI Fixes milestone May 10, 2021
@ericclemmons ericclemmons added the UI Related to UI Components label May 10, 2021
Copy link
Contributor

@ericclemmons ericclemmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @wlee221 !

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
@jimblanc jimblanc deleted the hoc-pw-manager branch November 23, 2022 15:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
UI Related to UI Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants