-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export UsernameAttributes enum #5197
Conversation
This change makes it possible to specify the usernameAttribute prop in TypeScript without using `any`.
Codecov Report
@@ Coverage Diff @@
## master #5197 +/- ##
=======================================
Coverage 73.17% 73.17%
=======================================
Files 193 193
Lines 11449 11450 +1
Branches 2221 2221
=======================================
+ Hits 8378 8379 +1
Misses 2923 2923
Partials 148 148
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @selbekk !
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
This change makes it possible to specify the usernameAttribute prop in TypeScript without using
any
.Fixes #5196
Description of changes:
Here I've exposed the UsernameAttributes enum as a named export by exposing everything in the
common/types.ts
file.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.