-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@aws-amplify/auth): Easier Federation with OAuth #3005
Conversation
@powerful23 please review very carefully, including the code changes to |
To test:
You should see JWT tokens and/or AWS credentials in local storage, depending on the combination of User Pools/Identity Pools you have in your config file. You can also use |
Scope exist multiple times inside oauth, is that on purpose?
|
No just a typo. Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
@undefobj @powerful23 - I think this change introduced a few bugs in I'm seeing the following warning in our app after upgrading Furthermore, it's looking like this change broke our custom provider login using
I'd be happy to provide additional details if necessary! |
@jessedoyle Hi, thanks for reporting! Can you open an issue in the repo and link it to this pr? We will track it there. |
@powerful23 - Will do, thanks! |
If anyone familiar with how this PR works could look at https://github.com/aws-amplify/amplify-js/discussions/7971 and tell me what I'm doing wrong, I would greatly appreciate any help 🙏 |
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
Fixes #2716
Description of changes:
federatedSignIn
withOAuth
HOC to use new APIBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.