Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep foreign keys on native platforms when they are part of the primary key #887

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

dpilch
Copy link
Member

@dpilch dpilch commented Oct 2, 2024

Description of changes

Resolves: #880

Issue #, if available

Description of how you validated changes

  • Confirmed by doing a tagged release and verified TypeError is resolved on modelgen command
  • Confirmed with native mobile teams the change does not affect generated model files and no change needed on their end, attaching tickets for confirmation.

Checklist

  • PR description included
  • yarn test passes
  • E2E test run passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • Breaking changes to existing customers are released behind a feature flag or major version update
  • Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified
  • Changes are tested on windows. Some Node functions (such as path) behave differently on windows.
  • Changes adhere to the GraphQL Spec and supports the GraphQL types type, input, enum, interface, union and scalar types.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tejas2008 tejas2008 marked this pull request as ready for review January 9, 2025 18:15
@tejas2008 tejas2008 requested a review from a team as a code owner January 9, 2025 18:15
@fct-devops
Copy link

there is an issue if remove the foragn key!!. hope to merge this commit ASAP!

image

@dpilch dpilch force-pushed the composite-key-references branch from 47f8cce to cd50582 Compare January 21, 2025 23:05
@dpilch dpilch enabled auto-merge (squash) January 22, 2025 17:31
@dpilch dpilch merged commit b4c4af5 into main Jan 23, 2025
4 of 5 checks passed
@dpilch dpilch deleted the composite-key-references branch January 23, 2025 17:51
@fct-devops
Copy link

@dpilch how can I upgrade this package in my amplify app , I didn't find any dependecy on amplify-codegen, only found @aws-amplify/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError while generating modelgen in dart
4 participants