Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass improve pluralization flag #797

Merged
merged 1 commit into from
Mar 15, 2024
Merged

fix: pass improve pluralization flag #797

merged 1 commit into from
Mar 15, 2024

Conversation

dpilch
Copy link
Member

@dpilch dpilch commented Mar 14, 2024

Description of changes

  • pass improve pluralization flag (only affects Swift target)
  • This flag was missed when adding the graphql-generator
  • The flag overlaps with transformer version so customer are still able to activate the feature.
    const useImprovedPluralization = this.config.improvePluralization || (this.config.transformerVersion === 2);
  • We will need to make a breaking change to graphql-generator to change the default to true.

Codegen Paramaters Changed or Added

improvePluralization is being respected.

Issue #, if available

N/A

Description of how you validated changes

  • Unit testing

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dpilch dpilch requested review from a team as code owners March 14, 2024 20:25
@dpilch dpilch enabled auto-merge (squash) March 15, 2024 15:38
@dpilch dpilch merged commit 948577c into main Mar 15, 2024
4 checks passed
@dpilch dpilch mentioned this pull request Apr 1, 2024
2 tasks
@dpilch dpilch deleted the improve-pluralization branch July 31, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants