Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use default directives from @aws-amplify/graphql-directives #796

Merged
merged 8 commits into from
Mar 29, 2024

Conversation

dpilch
Copy link
Member

@dpilch dpilch commented Mar 14, 2024

Description of changes

  • Use new @aws-amplify/graphql-directives package as source of truth for directive definitions.
  • Set DefaultDirectives as default directives used for model generation in @aws-amplify/graphql-generator.

Codegen Paramaters Changed or Added

  • directives on GenerateModelsOptions changed to optional. DefaultDirectives from @aws-amplify/graphql-directives is used as the default.
  • @aws-amplify/graphql-directives is set with ^ dependency range. DefaultDirectives can be updated by the customer if desired.

Issue #, if available

N/A

Description of how you validated changes

  • Unit tests
  • E2E tests

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dpilch dpilch force-pushed the default-directives branch 2 times, most recently from 00e2e8f to 0b3d0a5 Compare March 19, 2024 21:29
@dpilch dpilch changed the title Default directives feat: use default directives from @aws-amplify/graphql-directives Mar 19, 2024
@dpilch dpilch marked this pull request as ready for review March 28, 2024 21:26
@dpilch dpilch requested review from a team as code owners March 28, 2024 21:26
@dpilch dpilch enabled auto-merge (squash) March 29, 2024 13:39
@dpilch dpilch merged commit a94649e into main Mar 29, 2024
4 of 5 checks passed
@dpilch dpilch deleted the default-directives branch March 29, 2024 19:36
@dpilch dpilch mentioned this pull request Apr 1, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants