-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: process input object, union and interface metadata in model introspection schema codegen #795
Conversation
f6bc18d
to
3e5fe03
Compare
packages/amplify-codegen-e2e-tests/src/__tests__/push-codegen-admin-modelgen.test.ts
Outdated
Show resolved
Hide resolved
packages/amplify-codegen-e2e-tests/src/__tests__/push-codegen-admin-modelgen.test.ts
Show resolved
Hide resolved
packages/amplify-codegen-e2e-tests/src/__tests__/push-codegen-admin-modelgen.test.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change responds to the opt-in regions used for e2e tests, which is similar to the related cleanup script change in API category
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Granting admin approval after reviewing API.md
and .codebuild/*
changes. Did not review implementation changes.
Description of changes
The
input
,union
andinterface
types are correctly processed by the base visitor when it is defined in the GQL schema. The union and interface IR, however, will not be processed into the output of MISCodegen Parameters Changed or Added
The type of model schema is changed
Input
ExampleGiven the GraphQL schema in SDL
The corresponding part will be generated in model introspection schema
Union
&Interface
Union and Interface types will not be generated in the MIS json file. The fields with these types will be omitted when they present in type definition. They can still be recognized as it is being processed in the base visitor
Issue #, if available
Fix #794
Description of how you validated changes
Checklist
yarn test
passespath
) behave differently on windows.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.