Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default for no gql config case #600

Merged
merged 2 commits into from
May 25, 2023
Merged

Conversation

phani-srikar
Copy link
Contributor

Description of changes

Adds a default return if the codegen config file does not exist to avoid breaking the pre/post push flows.

Issue #, if available

Description of how you validated changes

Added unit test.
Sample JS app.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • Breaking changes to existing customers are released behind a feature flag or major version update
  • Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phani-srikar phani-srikar requested a review from a team as a code owner May 25, 2023 21:59
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2023

Codecov Report

Merging #600 (a9ac730) into main (2d17486) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #600      +/-   ##
==========================================
+ Coverage   85.85%   85.92%   +0.06%     
==========================================
  Files         152      152              
  Lines        7487     7493       +6     
  Branches     1957     1959       +2     
==========================================
+ Hits         6428     6438      +10     
+ Misses        963      962       -1     
+ Partials       96       93       -3     
Impacted Files Coverage Δ
...codegen/src/codegen-config/AmplifyCodeGenConfig.js 46.98% <100.00%> (+9.32%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@phani-srikar phani-srikar merged commit b438232 into main May 25, 2023
@alharris-at alharris-at deleted the fix-graphql-config branch July 10, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants