fix: skip issues correctly

aws-actions · Apr 24, 2020 · 1c718ea · 1c718ea
1 parent be318db
commit 1c718ea
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/entrypoint.js b/src/entrypoint.js
@@ -93,10 +93,11 @@ async function processIssues(client, args) {
     if (isLabeled(issue, staleLabel)) {
       log.debug(`issue contains the stale label`);
       const lastCommentTime = getLastCommentTime(issueTimelineEvents);
-      const staleLabelTime = getLastLabelTime(issueTimelineEvents, staleLabel);
+      const stLabelTime = getLastLabelTime(issueTimelineEvents, staleLabel);
       const sTime = new Date(
         lastCommentTime + MS_PER_DAY * args.daysBeforeClose
       );
+      const staleLabelTime = stLabelTime === undefined ? sTime : stLabelTime;
       if (lastCommentTime > staleLabelTime) {
         log.debug('issue was commented on after the label was applied');
         if (args.dryrun) {

diff --git a/src/utils.js b/src/utils.js
@@ -56,8 +56,8 @@ module.exports.getLastLabelTime = (events, label) => {
     log.warn(
       `Could not find a ${label} label event in this issue's timeline. Was this label renamed?`
     );
-    log.warn('Defaulting the label time to now so we skip over this issue');
-    return new Date(Date.now());
+    log.warn('Skipping over this issue');
+    return undefined;
   }
 };