feat: Add configurable update rate #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
taoyong-ty
reviewed
Jan 27, 2023
code-build.js
Outdated
| @@ -87,16 +90,17 @@ async function waitForBuildEndTime( | |||
| //We caught an error in trying to make the AWS api call, and are now checking to see if it was just a rate limiting error | |||
| if (errObject.message && errObject.message.search("Rate exceeded") !== -1) { | |||
| //We were rate-limited, so add `backOff` seconds to the wait time | |||
| let newWait = wait + backOff; | |||
| let newWait = updateInterval + updateBackOff; | |||
There was a problem hiding this comment.
can you add a random jitter to this?
https://aws.amazon.com/blogs/architecture/exponential-backoff-and-jitter/
There was a problem hiding this comment.
Applied Full Jitter to the added backoff now. If/when the backoff implementation looks good, I also need to update the backoff description in relevant places.
vililahtevanoja
force-pushed
the
master
branch
from
410dc4e to
277b660
Compare
taoyong-ty
reviewed
Jan 29, 2023
taoyong-ty
approved these changes
Jan 30, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #76
Description of changes:
Default values are kept the same (30s interval, 15s back-off), so there should be no breakage when updating.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable:
Supercedes #77 (which can be closed).