-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump and migrate pyo3 to 0.21 #121
base: master
Are you sure you want to change the base?
Conversation
Any progress of this? It sort of block our migration. |
@awestlake87 Are there any subtasks here you need a hand with? |
@jopemachine I think the changes for |
It is already reverted in df5f892 (Reverted words misunderstood as typo) |
I'm still seeing changes at the head of this branch for I must be misunderstanding - this PR is also reverting previous changes which were considered typos I'm assuming. |
Hi! Is there anything we can do to help port this over? We're currently blocked in migrating to a newer PyO3 version for this. |
As per #119 (comment) While waiting for a permanent decision on what to do, I've published https://crates.io/crates/pyo3-asyncio-0-21 from a fork at https://github.com/davidhewitt/pyo3-asyncio |
Thank you for contributing to pyo3-asyncio!
Please consider adding the following to your pull request:
Be aware the CI pipeline will check your pull request for the following:
cargo test
)make clippy
)cargo fmt
)black . --check
. You can install black withpip install black
)Fixes #119.
Ref: https://pyo3.rs/v0.21.0/migration.html
I've updated pyo3-asyncio code referring to the migration guide.
I'd appreciate it if you could let me know if there's anything I've missed.