Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Lite 1.x functionality (admin notice only) #72

Closed
pderksen opened this issue Mar 13, 2019 · 1 comment
Closed

Deprecate Lite 1.x functionality (admin notice only) #72

pderksen opened this issue Mar 13, 2019 · 1 comment
Milestone

Comments

@pderksen
Copy link
Contributor

pderksen commented Mar 13, 2019

In June 2017, we launched rewrites of both Lite and Pro to use custom post types. Before that they were purely shortcode based.

For Pro, this meant a brand new version (3.0). For Lite, we bumped the version to 2.0 but kept the 1.x "legacy" settings available.

In June 2018, we ended support for Pro 2.x. In Lite, now that we're in March 2019, I'm thinking it's nearing time to remove the 1.x settings.

In case some Lite users are still using the old shortcodes and settings, let's discuss how we'll warn and phase it out over the next few releases.

I'm thinking similar to how we'll be phasing out old versions of PHP: first #58 then #71. Break this out into two issues as well if it makes sense.

See #75 for actual removal of 1.x code.

Not sure if it matters, but 1.x used the [stripe] shortcode while 2.x uses [simpay].

@spencerfinnell spencerfinnell added this to the 2.1.0 milestone Mar 13, 2019
@spencerfinnell
Copy link
Contributor

For the 2.1.0 release we will show a notice prompting users to migrate their [stripe] shortcodes to [simpay] if useres DO have a legacy API key but do NOT have a 2.x key (or Stripe Connect auth).

@pderksen pderksen changed the title Deprecate Lite 1.x functionality Deprecate Lite 1.x functionality (admin notice only) Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants