Emit wallpaper_changed less often #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 222f0a1 optimised the case where we change the wallpaper so that we can give the new wallpaper to Lua faster. However, contrary to what was intended, it also caused another wallpaper update later when the server told us that the wallpaper actually changed. This was because the juggling with multiple X11 connections went wrong. Fix this by using the right connection to actually change the wallpaper. Signed-off-by: Uli Schlachter <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1800 +/- ##
==========================================
- Coverage 79.28% 79.24% -0.04%
==========================================
Files 363 363
Lines 25793 25794 +1
Branches 982 982
==========================================
- Hits 20450 20441 -9
- Misses 5339 5350 +11
+ Partials 4 3 -1
Continue to review full report at Codecov.
|
|
Thanks! |
petoju
pushed a commit
to petoju/awesome
that referenced
this pull request
Sep 10, 2017
Commit 222f0a1 optimised the case where we change the wallpaper so that we can give the new wallpaper to Lua faster. However, contrary to what was intended, it also caused another wallpaper update later when the server told us that the wallpaper actually changed. This was because the juggling with multiple X11 connections went wrong. Fix this by using the right connection to actually change the wallpaper. Signed-off-by: Uli Schlachter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 222f0a1 optimised the case where we change the wallpaper
so that we can give the new wallpaper to Lua faster. However, contrary
to what was intended, it also caused another wallpaper update later when
the server told us that the wallpaper actually changed. This was because
the juggling with multiple X11 connections went wrong.
Fix this by using the right connection to actually change the wallpaper.
Signed-off-by: Uli Schlachter [email protected]