Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avocado.utils lint checks enablement #6114

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

richtja
Copy link
Contributor

@richtja richtja commented Feb 3, 2025

This is a collection of lint checks, enablement for avocado.utils to make avocado utils align with Autils style conventions.

Reference: #6034

@richtja richtja added this to the 110 - Codename TBD milestone Feb 3, 2025
@richtja richtja self-assigned this Feb 3, 2025
@richtja richtja marked this pull request as draft February 3, 2025 14:12
@richtja richtja force-pushed the avocado.utils_lint branch 2 times, most recently from 461056f to 12d7570 Compare February 6, 2025 15:08
@richtja richtja marked this pull request as ready for review February 6, 2025 15:08
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 23.82812% with 390 lines in your changes missing coverage. Please review.

Project coverage is 68.89%. Comparing base (f986a03) to head (f87e60e).

Files with missing lines Patch % Lines
avocado/utils/network/interfaces.py 0.00% 86 Missing ⚠️
avocado/utils/software_manager/main.py 0.00% 48 Missing ⚠️
avocado/utils/external/spark.py 30.35% 39 Missing ⚠️
avocado/utils/lv_utils.py 0.00% 23 Missing ⚠️
avocado/utils/multipath.py 0.00% 23 Missing ⚠️
avocado/utils/pci.py 0.00% 23 Missing ⚠️
avocado/utils/download.py 5.55% 17 Missing ⚠️
avocado/utils/software_manager/backends/rpm.py 8.33% 11 Missing ⚠️
avocado/utils/software_manager/backends/base.py 25.00% 9 Missing ⚠️
avocado/utils/sysinfo.py 0.00% 9 Missing ⚠️
... and 31 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6114      +/-   ##
==========================================
- Coverage   68.92%   68.89%   -0.04%     
==========================================
  Files         203      203              
  Lines       21999    22017      +18     
==========================================
+ Hits        15163    15168       +5     
- Misses       6836     6849      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clebergnu clebergnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @richtja,

This one took me a while (and it surely took you even more time), so thanks a lot! It looks good to me, and I tried to solve the conflicts at merge time, but the changes are quite big.

I guess it's better to rebase this and make it go through CI again.

To keep the API stability let's dissable it for current API, but enforce
it in the future.

Signed-off-by: Jan Richter <[email protected]>
To keep the API stability let's dissable it for current API, but
enforce it in the future.

Signed-off-by: Jan Richter <[email protected]>
@richtja
Copy link
Contributor Author

richtja commented Feb 18, 2025

Hi @clebergnu, I did a rebase to resolve conflicts with the master. Please take a look.

@richtja richtja requested a review from clebergnu February 18, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review Requested
Development

Successfully merging this pull request may close these issues.

avocado.utils: use default pylintrc configuration from avocado-static-checks
2 participants