veri: disallow duplicate specs #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcloughlin
commented
Nov 28, 2023
| @@ -4567,35 +4567,6 @@ | |||
| (if (ty_int_ref_scalar_64 ty)) | |||
| (flags_and_cc (cmp (operand_size ty) rn rm) cond)) | |||
|
|
|||
| (spec (lower_icmp_const c x y in_ty) | |||
There was a problem hiding this comment.
@avanhatt Which of the specs should be kept?
There was a problem hiding this comment.
On first glance, they look equivalent, but the one with the specific enum names (the one deleted here) is a little cleaner to read IMO. Let's keep this one instead.
avanhatt
requested changes
Nov 29, 2023
| @@ -4567,35 +4567,6 @@ | |||
| (if (ty_int_ref_scalar_64 ty)) | |||
| (flags_and_cc (cmp (operand_size ty) rn rm) cond)) | |||
|
|
|||
| (spec (lower_icmp_const c x y in_ty) | |||
There was a problem hiding this comment.
On first glance, they look equivalent, but the one with the specific enum names (the one deleted here) is a little cleaner to read IMO. Let's keep this one instead.
mmcloughlin
force-pushed
the
mbm/disallow-dupe-specs
branch
from
4ec32ef to
514bf33
Compare
avanhatt
approved these changes
Dec 13, 2023
mmcloughlin
force-pushed
the
mbm/disallow-dupe-specs
branch
from
514bf33 to
287d3f7
Compare
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Oct 9, 2024
Now we have the `(with ...)` scope there is no need to use unique `v<i>_<j>` prefixes for temporary variables. This PR switches to use `t<i>` names. Aside from looking nicer it also removes a piece of config we need to track. Updates avanhatt#62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR errors when duplicate specs are provided.
We currently have two for
lower_icmp_const:wasmtime/cranelift/codegen/src/isa/aarch64/inst.isle
Line 4495 in 6578776
wasmtime/cranelift/codegen/src/isa/aarch64/inst.isle
Line 4565 in 6578776