Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI, errors in latest beta #1840

Merged
merged 3 commits into from
Jun 13, 2018
Merged

Fix CI, errors in latest beta #1840

merged 3 commits into from
Jun 13, 2018

Conversation

novemberborn
Copy link
Member

This makes tests pass on Travis again. It's not great, I think once we get a 1.0 out we should look into testing AVA with the previous stable release.

This fixes #1836. @vladimiry could you give it a try? You shouldn't need babel: false anymore.

This also fixes #1826. @jdalton I cloned esm and linked my local AVA install, removing your CI env workarounds. Tests passed so yay! But perhaps you could give it a try as well?

Will merge and ship tomorrow.

Tests from this file are now consistently timing out in TravisCI. Split
across multiple files in the hope that this reduces the failure rate.
@vladimiry
Copy link

vladimiry commented Jun 12, 2018

@novemberborn Just tried version from the fixes branch, works well for me without babel: false` option set, thanks.

@jdalton
Copy link
Contributor

jdalton commented Jun 12, 2018

Thank you @novemberborn!

@novemberborn novemberborn merged commit 09f2d87 into master Jun 13, 2018
@novemberborn novemberborn deleted the fixes branch June 13, 2018 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants