Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log typescript errors to console #1834

Merged
merged 12 commits into from
Jun 13, 2018
Merged

log typescript errors to console #1834

merged 12 commits into from
Jun 13, 2018

Conversation

btkostner
Copy link
Contributor

Fixes TS building issue not being outputted

Mentioned in #1822

@novemberborn
Copy link
Member

This looks good!

I realize this may be a bit of a stretch, but perhaps you could try and write an integration test for this? See https://github.com/avajs/ava/blob/master/test/reporters/mini.js (and verbose.js) and https://github.com/avajs/ava/blob/master/test/helper/report.js for the starting points.

@btkostner
Copy link
Contributor Author

I'll take a look at that tonight and see what I can get done!

@@ -1,23 +1,22 @@
'use strict';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes were made by the linter

@btkostner
Copy link
Contributor Author

I added tests for the reporters. They include stack traces because of the errors, but I'm not sure the best way to clear those. Assuming that ts-node doesn't change we should be good though.

I wasn't seeing the error on my machine.
Don't print source or stack traces for TSError's that come with
diagnostic text. Print the text like we do stack traces and remove any
leading or trailing linebreaks.
@novemberborn
Copy link
Member

Thanks @btkostner! I've taken the liberty to push some changes as I'd like to get this into today's release. Weirdly I couldn't get compile errors out of the code you pushed.

@novemberborn
Copy link
Member

Phew, fixed the CI failure in the TAP reporter by just not checking the TypeScript output 👼

@novemberborn novemberborn merged commit 5cce79a into avajs:master Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants