-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log typescript errors to console #1834
Conversation
This looks good! I realize this may be a bit of a stretch, but perhaps you could try and write an integration test for this? See https://github.com/avajs/ava/blob/master/test/reporters/mini.js (and |
I'll take a look at that tonight and see what I can get done! |
test/fixture/source-map-initial.js
Outdated
@@ -1,23 +1,22 @@ | |||
'use strict'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes were made by the linter
I added tests for the reporters. They include stack traces because of the errors, but I'm not sure the best way to clear those. Assuming that |
I wasn't seeing the error on my machine.
Don't print source or stack traces for TSError's that come with diagnostic text. Print the text like we do stack traces and remove any leading or trailing linebreaks.
Thanks @btkostner! I've taken the liberty to push some changes as I'd like to get this into today's release. Weirdly I couldn't get compile errors out of the code you pushed. |
It's output is wonky on Windows, but there is no special logic so no need to test anything.
Phew, fixed the CI failure in the TAP reporter by just not checking the TypeScript output 👼 |
Fixes TS building issue not being outputted
Mentioned in #1822