Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test context type missing end (at least in callback test) #1347

Closed
mightyiam opened this issue Apr 6, 2017 · 2 comments · Fixed by singapore/gl-got#20
Closed

Test context type missing end (at least in callback test) #1347

mightyiam opened this issue Apr 6, 2017 · 2 comments · Fixed by singapore/gl-got#20
Assignees
@novemberborn
Labels
bug current functionality does not work as desired

Comments

@mightyiam
Copy link
Contributor

Description

Default t type for at least callback tests is missing t.end.

screenshot_2017-04-06_13-09-30

Relevant Links

https://github.com/mightyiam/cyclejs-components/pull/122

Environment

Node.js v7.8.0
linux 4.10.0-15-generic
npm 4.2.0
ava 0.19.0
@novemberborn novemberborn self-assigned this Apr 6, 2017
@novemberborn novemberborn added the bug current functionality does not work as desired label Apr 6, 2017
novemberborn added a commit that referenced this issue Apr 6, 2017
@novemberborn
Fix TypeScript definition for callback tests
33dcf44 
Fixes #1347
@novemberborn novemberborn mentioned this issue Apr 6, 2017
Merged
novemberborn added a commit that referenced this issue Apr 10, 2017
@novemberborn
Fix TypeScript definition for callback tests
bd81ef4 
Fixes #1347
@renovate-bot renovate-bot mentioned this issue Apr 10, 2017
Merged
@mightyiam
Copy link
Contributor Author

Thanks, @novemberborn !

Hey, but, for the record, the context is t.context, and not t, as suggested above, right?

@novemberborn
Copy link
Member

t is the "execution context" 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@novemberborn novemberborn

Labels
bug current functionality does not work as desired
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update dependency ava to version 0.19.1 singapore/gl-got
2 participants
@novemberborn @mightyiam