Skip to content

Commit

Permalink
fix: pylint checks in connectors/sqla/models.py (apache#10974)
Browse files Browse the repository at this point in the history
* Removed unused pylint rule `too-many-instance-attributes` from SqlaTable class.

* Removed unecessary rule: `bad-whitespace` from `get_sqla_query` method

* Disabling too-many-instance-attributes since it fails on CI
  • Loading branch information
kkucharc authored and auxten committed Nov 20, 2020
1 parent ec77f6a commit dcc1a6d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion superset/connectors/sqla/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,7 @@ def get_sqla_query( # pylint: disable=too-many-arguments,too-many-locals,too-ma
groupby: Optional[List[str]] = None,
filter: Optional[ # pylint: disable=redefined-builtin
List[Dict[str, Any]]
] = None, # pylint: disable=bad-whitespace
] = None,
is_timeseries: bool = True,
timeseries_limit: int = 15,
timeseries_limit_metric: Optional[Metric] = None,
Expand Down

0 comments on commit dcc1a6d

Please sign in to comment.