Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flush reporter instead of closing #3

Merged
merged 2 commits into from
Feb 14, 2022
Merged

fix: flush reporter instead of closing #3

merged 2 commits into from
Feb 14, 2022

Conversation

cawolf
Copy link
Member

@cawolf cawolf commented Feb 14, 2022

During the dev_v3 development, there was a change in handling flush() for reporters: instead of using flush(), now close() was used.

This leads to the fact that you can use flush() on the tracer only once, which is a change which breaks e.g. our rabbitmq bundle.

We reintroduced flush() for reporters and use it instead of close().

@cawolf cawolf added the bug Something isn't working label Feb 14, 2022
@cawolf cawolf requested a review from MollocH February 14, 2022 07:43
Copy link

@MollocH MollocH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cawolf cawolf merged commit 970aae8 into master Feb 14, 2022
@cawolf cawolf deleted the flush-reporter branch February 14, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants