Prepare for evm-tracker pallet in subspace runtime #3376
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow the domain owner to change the EVM contract creation allow list, we need to add a call to the subspace runtime, which gets turned into an inherent for the EVM domain runtime.
To do this,
pallet-evm-tracker
needs to be in both the EVM and subspace runtimes.Unfortunately, this causes some compilation issues:
AccountId
types are different across these runtimesTo avoid these issues, this PR:
EthereumAccountId
type in all code that deals with contract creation filterscreate-contract-filter
feature toevm-tracker
, which is only activated in the EVM runtime (we need the call in the subspace runtime, and the filters in the EVM runtime)I checked this works in the subspace runtime using this branch (but I don't want to merge that until we actually have calls and inherents working):
https://github.com/autonomys/subspace/tree/private-evm-subspace-pallet
Code contributor checklist: