Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for evm-tracker pallet in subspace runtime #3376

Closed
wants to merge 2 commits into from

Conversation

teor2345
Copy link
Member

To allow the domain owner to change the EVM contract creation allow list, we need to add a call to the subspace runtime, which gets turned into an inherent for the EVM domain runtime.

To do this, pallet-evm-tracker needs to be in both the EVM and subspace runtimes.

Unfortunately, this causes some compilation issues:

  • the AccountId types are different across these runtimes
  • there are "unimplemented trait" errors in some of the ethereum pallets

To avoid these issues, this PR:

  • uses the EthereumAccountId type in all code that deals with contract creation filters
  • adds a create-contract-filter feature to evm-tracker, which is only activated in the EVM runtime (we need the call in the subspace runtime, and the filters in the EVM runtime)

I checked this works in the subspace runtime using this branch (but I don't want to merge that until we actually have calls and inherents working):
https://github.com/autonomys/subspace/tree/private-evm-subspace-pallet

Code contributor checklist:

Copy link
Member

@vedhavyas vedhavyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding EVM tracker to Consensus runtime is not required since its going to be a storage and a call.

Please add it to the pallet-domains so domain related stuff is all contained within it

@teor2345 teor2345 marked this pull request as draft February 10, 2025 10:04
@teor2345
Copy link
Member Author

This isn't going to work this way, I'll open separate PRs for the feature and non-essential changes.

@teor2345 teor2345 closed this Feb 12, 2025
@teor2345 teor2345 deleted the private-evm-types branch February 18, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants